Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tournament games #2807

Draft
wants to merge 9 commits into
base: develop
Choose a base branch
from
Draft

Tournament games #2807

wants to merge 9 commits into from

Conversation

1-alex98
Copy link
Member

No description provided.

@1-alex98
Copy link
Member Author

FAForever/server#675

@1-alex98 1-alex98 force-pushed the feature/tournament branch 2 times, most recently from 9fc9f82 to 2015685 Compare September 24, 2022 22:23
@codecov
Copy link

codecov bot commented Sep 24, 2022 •
edited
Loading

Codecov Report

Merging #2807 (ab6e883) into develop (d6a9dd1) will decrease coverage by 0.48%.
The diff coverage is 32.63%.

❗ Current head ab6e883 differs from pull request most recent head 6aa418c. Consider uploading reports for the commit 6aa418c to get more accurate results

Additional details and impacted files 
@@              Coverage Diff              @@
##             develop    #2807      +/-   ##
=============================================
- Coverage      65.50%   65.02%   -0.49%     
+ Complexity      5071     5002      -69     
=============================================
  Files            553      534      -19     
  Lines          20700    20752      +52     
  Branches        1159     1181      +22     
=============================================
- Hits           13559    13493      -66     
- Misses          6466     6585     +119     
+ Partials         675      674       -1
Impacted Files Coverage Δ
...forever/client/leaderboard/LeaderboardService.java 97.81% <0.00%> (-1.46%) ⬇️
...java/com/faforever/client/main/MainController.java 52.23% <0.00%> (+0.23%) ⬆️
...com/faforever/client/remote/FafServerAccessor.java 77.07% <0.00%> (-1.00%) ⬇️
...t/ui/preferences/GameDirectoryRequiredHandler.java 44.44% <0.00%> (ø)
.../client/ui/progress/RingProgressIndicatorSkin.java 0.00% <0.00%> (ø)
...er/client/ui/progress/ProgressCircleIndicator.java 23.52% <23.52%> (ø)
...ever/client/ui/progress/RingProgressIndicator.java 24.13% <24.13%> (ø)
...ver/client/notification/ImmediateNotification.java 54.16% <27.27%> (-19.17%) ⬇️
...ain/java/com/faforever/client/theme/UiService.java 39.43% <33.33%> (-0.41%) ⬇️
.../client/tournament/game/TournamentGameService.java 55.55% <55.55%> (ø)
... and 93 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60752fc...6aa418c. Read the comment docs.

Sheikah45
Sheikah45 requested changes Sep 24, 2022
View reviewed changes
Copy link
Member

@Sheikah45 Sheikah45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will have to see the indicator in action XD

src/main/java/com/faforever/client/game/GameService.java Outdated Show resolved Hide resolved
src/main/java/com/faforever/client/game/GameService.java Outdated Show resolved Hide resolved
src/main/java/com/faforever/client/game/GameService.java Outdated Show resolved Hide resolved
src/main/java/com/faforever/client/game/GameService.java Outdated Show resolved Hide resolved
src/main/java/com/faforever/client/game/GameService.java Outdated Show resolved Hide resolved
src/main/java/com/faforever/client/tournament/game/TournamentGameService.java Outdated Show resolved Hide resolved
src/main/java/com/faforever/client/tournament/game/TournamentGameService.java Show resolved Hide resolved
src/main/java/com/faforever/client/ui/progress/ProgressCircleIndicator.java Outdated Show resolved Hide resolved
src/main/java/com/faforever/client/ui/progress/ProgressCircleIndicator.java Show resolved Hide resolved
src/main/resources/application-local.yml Show resolved Hide resolved
@1-alex98
Copy link
Member Author

1-alex98 commented Sep 25, 2022 •
edited
Loading

Thx for the review should have addressed almost all of it. And commented the rest.

@Sheikah45
Copy link
Member

Will look at this again soon

Sheikah45
Sheikah45 reviewed Nov 24, 2022
View reviewed changes
Copy link
Member

@Sheikah45 Sheikah45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like it is in a pretty good state. Does this need any changes on the server?

@1-alex98
Copy link
Member Author

Seems like it is in a pretty good state. Does this need any changes on the server?

yes but it will not hurt having it in the client before that is done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sheikah45 Sheikah45 Sheikah45 requested changes

@Brutus5000 Brutus5000 Awaiting requested review from Brutus5000

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@1-alex98 @Sheikah45